Discussion:
[PATCH 1/1] GUI: Add a tuna.desktop file
Guy Streeter
2013-12-03 20:10:31 UTC
Permalink
A non-text attachment was scrubbed...
Name: 0001-Add-a-tuna.desktop-file-so-the-tuna-GUI-can-be-start.patch
Type: text/x-patch
Size: 1475 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/tuna-devel/attachments/20131203/2973d7f4/attachment.bin>
Guy Streeter
2013-12-03 20:12:25 UTC
Permalink
_______________________________________________
tuna-devel mailing list
tuna-devel at lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/tuna-devel
Was I supposed to put the patch file inline, or is an attachment OK?
--Guy
John Kacur
2013-12-04 13:00:20 UTC
Permalink
Personally, I prefer inline, but either should be okay.

----- Original Message -----
Post by Guy Streeter
_______________________________________________
tuna-devel mailing list
tuna-devel at lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/tuna-devel
Was I supposed to put the patch file inline, or is an attachment OK?
--Guy
_______________________________________________
tuna-devel mailing list
tuna-devel at lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/tuna-devel
Jiri Kastner
2014-01-30 11:28:01 UTC
Permalink
not accepted, look for next message.
j.
From f7747d9f2ec9fbf416866907d69572f3e86a79b5 Mon Sep 17 00:00:00 2001
From: Guy Streeter <streeter at redhat.com>
Date: Tue, 3 Dec 2013 14:04:06 -0600
Subject: [PATCH] Add a tuna.desktop file, so the tuna GUI can be started from
the desktop.
Signed-off-by: Guy Streeter <streeter at redhat.com>
---
rpm/SPECS/tuna.spec | 2 ++
tuna.desktop | 6 ++++++
2 files changed, 8 insertions(+)
create mode 100644 tuna.desktop
diff --git a/rpm/SPECS/tuna.spec b/rpm/SPECS/tuna.spec
index 9393df6..105a4ee 100644
--- a/rpm/SPECS/tuna.spec
+++ b/rpm/SPECS/tuna.spec
@@ -63,6 +63,7 @@ install -p -m644 docs/tuna.8 %{buildroot}/%{_mandir}/man8/
install -p -m644 etc/tuna/example.conf %{buildroot}/%{_sysconfdir}/tuna/
install -p -m644 etc/tuna.conf %{buildroot}/%{_sysconfdir}/
install -p -m644 org.tuna.policy %{buildroot}/%{_datadir}/polkit-1/actions/
+desktop-file-install --dir=%{buildroot}/%{_datadir}/applications tuna.desktop
# l10n-ed message catalogues
for lng in `cat po/LINGUAS`; do
@@ -89,6 +90,7 @@ rm -rf %{buildroot}
%{_sysconfdir}/tuna.conf
%{_sysconfdir}/tuna/*
%{_datadir}/polkit-1/actions/org.tuna.policy
+%{_datadir}/applications/tuna.desktop
%files -n oscilloscope
%defattr(-,root,root,-)
diff --git a/tuna.desktop b/tuna.desktop
new file mode 100644
index 0000000..f5febc0
--- /dev/null
+++ b/tuna.desktop
@@ -0,0 +1,6 @@
+[Desktop Entry]
+Name=tuna
+GenericName=Application Tuner
+Exec=tuna --gui
+Type=Application
+Terminal=false
--
1.8.3.1
_______________________________________________
tuna-devel mailing list
tuna-devel at lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/tuna-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/tuna-devel/attachments/20140130/57646124/attachment.sig>
Guy Streeter
2014-01-31 15:48:25 UTC
Permalink
not accepted, look for next message. j.
I have no idea how to do this in setup.py. The main reason setup.py
currently does very little is that the documentation for it is horrible.

- --Guy
From f7747d9f2ec9fbf416866907d69572f3e86a79b5 Mon Sep 17 00:00:00 2001
From: Guy Streeter <streeter at redhat.com> Date: Tue, 3 Dec 2013 14:04:06
-0600 Subject: [PATCH] Add a tuna.desktop file, so the tuna GUI can be
started from the desktop.
Signed-off-by: Guy Streeter <streeter at redhat.com> ---
rpm/SPECS/tuna.spec | 2 ++ tuna.desktop | 6 ++++++ 2 files
changed, 8 insertions(+) create mode 100644 tuna.desktop
diff --git a/rpm/SPECS/tuna.spec b/rpm/SPECS/tuna.spec index
9393df6..105a4ee 100644 --- a/rpm/SPECS/tuna.spec +++
%{buildroot}/%{_mandir}/man8/ install -p -m644 etc/tuna/example.conf
%{buildroot}/%{_sysconfdir}/tuna/ install -p -m644 etc/tuna.conf
%{buildroot}/%{_sysconfdir}/ install -p -m644 org.tuna.policy
%{buildroot}/%{_datadir}/polkit-1/actions/ +desktop-file-install
--dir=%{buildroot}/%{_datadir}/applications tuna.desktop
%{_sysconfdir}/tuna/* %{_datadir}/polkit-1/actions/org.tuna.policy
+%{_datadir}/applications/tuna.desktop
%files -n oscilloscope %defattr(-,root,root,-) diff --git
a/tuna.desktop b/tuna.desktop new file mode 100644 index
+[Desktop Entry] +Name=tuna +GenericName=Application Tuner +Exec=tuna
--gui +Type=Application +Terminal=false -- 1.8.3.1
_______________________________________________ tuna-devel mailing
list tuna-devel at lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/tuna-devel
_______________________________________________ tuna-devel mailing list
tuna-devel at lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/tuna-devel
Jiri Kastner
2014-02-04 10:12:16 UTC
Permalink
On Tue, 03 Dec 2013 14:10:31 -0600, Guy Streeter wrote:
i tested it on fc20 with mate desktop and i have few notes:
placed in menu under 'Applications/Other' instead of 'Application/System
tools' as it is something used for system tuning or under 'System/
Administration' as it requires root privileges.
following need to be added to have Icon and placed under correct menu:


Icon=preferences-desktop
Categories=System;Settings;
From f7747d9f2ec9fbf416866907d69572f3e86a79b5 Mon Sep 17 00:00:00 2001
From: Guy Streeter <streeter at redhat.com>
Date: Tue, 3 Dec 2013 14:04:06 -0600 Subject: [PATCH] Add a tuna.desktop
file, so the tuna GUI can be started from
the desktop.
Signed-off-by: Guy Streeter
<streeter at redhat.com>
---
rpm/SPECS/tuna.spec | 2 ++
tuna.desktop | 6 ++++++
2 files changed, 8 insertions(+)
create mode 100644 tuna.desktop
diff --git a/rpm/SPECS/tuna.spec b/rpm/SPECS/tuna.spec index
9393df6..105a4ee 100644 --- a/rpm/SPECS/tuna.spec +++
%{buildroot}/%{_mandir}/man8/
install -p -m644 etc/tuna/example.conf
%{buildroot}/%{_sysconfdir}/tuna/ install -p -m644 etc/tuna.conf
%{buildroot}/%{_sysconfdir}/
install -p -m644 org.tuna.policy
%{buildroot}/%{_datadir}/polkit-1/actions/
+desktop-file-install --dir=%{buildroot}/%{_datadir}/applications
tuna.desktop
# l10n-ed message catalogues for lng in `cat po/LINGUAS`; do
@@ -89,6 +90,7 @@ rm -rf %{buildroot}
%{_sysconfdir}/tuna.conf %{_sysconfdir}/tuna/*
%{_datadir}/polkit-1/actions/org.tuna.policy
+%{_datadir}/applications/tuna.desktop
%files -n oscilloscope %defattr(-,root,root,-)
diff --git a/tuna.desktop b/tuna.desktop new file mode 100644 index
+[Desktop Entry]
+Name=tuna +GenericName=Application Tuner +Exec=tuna --gui
+Type=Application +Terminal=false
Jiri Kastner
2014-02-05 15:58:07 UTC
Permalink
translated: i'm going to accept next version with spec file changes, but tuna.desktop file needs, at least, define Icon (i selected that icon which wm give to tuna) and some proper place under desktop menu like System/Settings.
Post by Jiri Kastner
placed in menu under 'Applications/Other' instead of 'Application/System
tools' as it is something used for system tuning or under 'System/
Administration' as it requires root privileges.
Icon=preferences-desktop
Categories=System;Settings;
From f7747d9f2ec9fbf416866907d69572f3e86a79b5 Mon Sep 17 00:00:00 2001
From: Guy Streeter <streeter at redhat.com>
Date: Tue, 3 Dec 2013 14:04:06 -0600 Subject: [PATCH] Add a tuna.desktop
file, so the tuna GUI can be started from
the desktop.
Signed-off-by: Guy Streeter
<streeter at redhat.com>
---
rpm/SPECS/tuna.spec | 2 ++
tuna.desktop | 6 ++++++
2 files changed, 8 insertions(+)
create mode 100644 tuna.desktop
diff --git a/rpm/SPECS/tuna.spec b/rpm/SPECS/tuna.spec index
9393df6..105a4ee 100644 --- a/rpm/SPECS/tuna.spec +++
%{buildroot}/%{_mandir}/man8/
install -p -m644 etc/tuna/example.conf
%{buildroot}/%{_sysconfdir}/tuna/ install -p -m644 etc/tuna.conf
%{buildroot}/%{_sysconfdir}/
install -p -m644 org.tuna.policy
%{buildroot}/%{_datadir}/polkit-1/actions/
+desktop-file-install --dir=%{buildroot}/%{_datadir}/applications
tuna.desktop
# l10n-ed message catalogues for lng in `cat po/LINGUAS`; do
@@ -89,6 +90,7 @@ rm -rf %{buildroot}
%{_sysconfdir}/tuna.conf %{_sysconfdir}/tuna/*
%{_datadir}/polkit-1/actions/org.tuna.policy
+%{_datadir}/applications/tuna.desktop
%files -n oscilloscope %defattr(-,root,root,-)
diff --git a/tuna.desktop b/tuna.desktop new file mode 100644 index
+[Desktop Entry]
+Name=tuna +GenericName=Application Tuner +Exec=tuna --gui
+Type=Application +Terminal=false
_______________________________________________
tuna-devel mailing list
tuna-devel at lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/tuna-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/tuna-devel/attachments/20140205/2c819f6b/attachment.sig>
Guy Streeter
2014-02-05 20:42:11 UTC
Permalink
Post by Jiri Kastner
translated: i'm going to accept next version with spec file changes, but
tuna.desktop file needs, at least, define Icon (i selected that icon
which wm give to tuna) and some proper place under desktop menu like
System/Settings.
On Tue, 03 Dec 2013 14:10:31 -0600, Guy Streeter wrote: i tested it on
fc20 with mate desktop and i have few notes: placed in menu under
'Applications/Other' instead of 'Application/System tools' as it is
something used for system tuning or under 'System/ Administration' as
it requires root privileges. following need to be added to have Icon
Icon=preferences-desktop Categories=System;Settings;
preferences-desktop doesn't seem like the right icon. Ideally, we should
come up with an icon specifically for tuna.
Barring that, I think preferences-system looks more appropriate.
- --Guy
Jiri Kastner
2014-02-05 21:22:59 UTC
Permalink
as i wrote before - i selected that icon, which i get from wm to tuna.
not trying to confuse user with some other one. when we will have own
icon, tuna.desktop can be changed.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Post by Jiri Kastner
translated: i'm going to accept next version with spec file changes,
but tuna.desktop file needs, at least, define Icon (i selected that
icon which wm give to tuna) and some proper place under desktop menu
like System/Settings.
On Tue, 03 Dec 2013 14:10:31 -0600, Guy Streeter wrote: i tested it on
fc20 with mate desktop and i have few notes: placed in menu under
'Applications/Other' instead of 'Application/System tools' as it is
something used for system tuning or under 'System/ Administration' as
it requires root privileges. following need to be added to have Icon
Icon=preferences-desktop Categories=System;Settings;
preferences-desktop doesn't seem like the right icon. Ideally, we should
come up with an icon specifically for tuna.
Barring that, I think preferences-system looks more appropriate.
- --Guy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1 Comment: Using GnuPG with Thunderbird -
http://www.enigmail.net/
iEYEARECAAYFAlLyoiMACgkQ0Bme0QyNhPRd8wCfeT0uhZEasMvj/scBXwC625Vi
em0AnjV4J1vS2QwRyf/hTIMTWnT+0Q12 =wxQO -----END PGP SIGNATURE-----
_______________________________________________
tuna-devel mailing list tuna-devel at lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/tuna-devel
Guy Streeter
2014-02-05 22:06:19 UTC
Permalink
Post by Jiri Kastner
as i wrote before - i selected that icon, which i get from wm to tuna.
not trying to confuse user with some other one. when we will have own
icon, tuna.desktop can be changed.
The preferences-desktop icon looks like an icon for something that would
modify the desktop. Perhaps we should leave out the icon until we have one of
our own?
--Guy
Jiri Kastner
2014-02-06 08:10:36 UTC
Permalink
well, i don't care how that icon looks like, what i care is that:
- desktop menu entry without icon doesn't look good (i want desktop entry with icon)
- in tuna_gui.py, line 86 is following:
<snip>
self.icon = gtk.status_icon_new_from_stock(gtk.STOCK_PREFERENCES)
<snip>
which is GTK_STOCK_PREFERENCES and that icon is same for kcontrol, gnome-settings, gtk-preferences, xfce4-settings, redhat-preferences, gnome-control-center and preferences-desktop
so better would be gtk-preferences as it corresponds with gtk.STOCK_PREFERENCES in code.

j.
Post by Guy Streeter
Post by Jiri Kastner
as i wrote before - i selected that icon, which i get from wm to tuna.
not trying to confuse user with some other one. when we will have own
icon, tuna.desktop can be changed.
The preferences-desktop icon looks like an icon for something that would
modify the desktop. Perhaps we should leave out the icon until we have one of
our own?
--Guy
_______________________________________________
tuna-devel mailing list
tuna-devel at lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/tuna-devel
Loading...