Discussion:
[PATCH] remove duplicate variable declaration in python-inet_diag
Joakim Hernberg
2015-07-04 09:09:21 UTC
Permalink
Hi don't know if this is the appropriate list, nor if I've really
cloned the right repo
(git://git.kernel.org/pub/scm/libs/python/python-inet_diag/python-inet_diag.git)?

But I seem to find this inconsistency in the code:

From e0d58c13239837b7b0ef44a13852c8ca1fa09440 Mon
Sep 17 00:00:00 2001 From: Joakim Hernberg <***@alchemy.lu>
Date: Sat, 4 Jul 2015 10:50:24 +0200
Subject: [PATCH] remove duplicate variable declaration in python-inet_diag

---
python-inet_diag/inet_diag.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/python-inet_diag/inet_diag.c b/python-inet_diag/inet_diag.c
index 7a209e0..7d78b13 100644
--- a/python-inet_diag/inet_diag.c
+++ b/python-inet_diag/inet_diag.c
@@ -103,8 +103,6 @@ static const int default_states = SS_ALL & ~((1 << SS_LISTEN) |

static const int listen_states = (1<<SS_LISTEN) | (1<<SS_CLOSE);

-static const int listen_states = (1<<SS_LISTEN) | (1<<SS_CLOSE);
-
static const char *tmr_name[] = {
"off",
"on",
--
2.4.5
--
Joakim
Jiri Kastner
2015-07-04 20:06:08 UTC
Permalink
yes, correct mailing list.
already noticed this problem, but fix not yet pushed to kernel.org.
patch is already in https://copr-be.cloud.fedoraproject.org/results/jkastner/Fedora-Realtime/fedora-rawhide-x86_64/python-inet_diag-0.2-1.fc22/python-inet_diag-0.2-1.fc23.src.rpm

it will be fine, if you'll extract that patch and sign-off, is already tested :)
thanks

best regards
jiri kastner
Joakim Hernberg
2015-07-05 12:13:47 UTC
Permalink
On Sat, 4 Jul 2015 20:06:08 +0000 (UTC)
Post by Jiri Kastner
yes, correct mailing list.
already noticed this problem, but fix not yet pushed to kernel.org.
patch is already in
https://copr-be.cloud.fedoraproject.org/results/jkastner/Fedora-Realtime/fedora-rawhide-x86_64/python-inet_diag-0.2-1.fc22/python-inet_diag-0.2-1.fc23.src.rpm
it will be fine, if you'll extract that patch and sign-off, is
already tested :) thanks
Sign-off on this mailing list? Though it really shouldn't need a
sign-off as it's more than evident what's wrong :)

Another question, isn't kernel.org supposed to create versioned tarballs
too, or is there some official location I can pick up said tarballs?
I'm packaging tuna for archlinux, so would be nicer to get tarballs,
than pull from git and checkout tags/commits/etc.
--
Joakim
Jiri Kastner
2015-07-07 11:44:30 UTC
Permalink
glad so tee, that it is packaged outside fedora/rhel. btw any idea or experience regarding getting distutils/setup.py to make installation less rpm dependent is welcome.

patch sign-off is not about triviality of fix, but its origin :)
Post by Joakim Hernberg
On Sat, 4 Jul 2015 20:06:08 +0000 (UTC)
Post by Jiri Kastner
yes, correct mailing list.
already noticed this problem, but fix not yet pushed to kernel.org.
patch is already in
https://copr-be.cloud.fedoraproject.org/results/jkastner/Fedora-Realtime/fedora-rawhide-x86_64/python-inet_diag-0.2-1.fc22/python-inet_diag-0.2-1.fc23.src.rpm
it will be fine, if you'll extract that patch and sign-off, is
already tested :) thanks
Sign-off on this mailing list? Though it really shouldn't need a
sign-off as it's more than evident what's wrong :)
Another question, isn't kernel.org supposed to create versioned tarballs
too, or is there some official location I can pick up said tarballs?
I'm packaging tuna for archlinux, so would be nicer to get tarballs,
than pull from git and checkout tags/commits/etc.
--
Joakim
Loading...